Add configuration options for pre- and post-filters #1314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
approved these changes
Jul 28, 2025
ts/core/OutputJax.ts
Outdated
| @@ -47,7 +47,12 @@ export interface OutputJax<N, T, D> { | |||
| options: OptionList; | |||
|
|
|||
| /** | |||
| * Lists of post-filters to call after typesetting the math | |||
| * Lists of pre-filters to call after typesetting the math | |||
There was a problem hiding this comment.
This is a single list not a list of lists?
There was a problem hiding this comment.
Right. The two lists used to be under one comment, but I split it for better jsdoc coverage, and neglected to fix the plural.
ts/core/OutputJax.ts
Outdated
| preFilters: FunctionList; | ||
|
|
||
| /** | ||
| * Lists of post-filters to call before typesetting the math |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1314 +/- ##
===========================================
- Coverage 86.71% 86.71% -0.01%
===========================================
Files 337 337
Lines 83979 84067 +88
Branches 4750 3129 -1621
===========================================
+ Hits 72826 72900 +74
- Misses 11130 11167 +37
+ Partials 23 0 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to have pre- and post-filters for the input and output jax be included in their configuration objects, rather than having to use the
startup.ready()function to add them. It also adds a pre-filter to the output jax, for symmetry (and because it may be easier to do filtering there than to have to add a post-filter onto each of the input jax if there are multiple input formats).To facilitate this, a new
addList()method is added to theFunctionListobject, and for good measure this is used in the TeX input jax to add its filters. You can also now pass a function list to theFunctionListconstructor. A new test is added to theFunctionListtests to cover the new code.